[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702368#comment-14702368
]
Chris Graham commented on MPIR-234:
-----------------------------------
We're mostly agreed on the first point.
It's the second that I have issues with. It sounds like you're saying "I'm not
going to change my mind, so I should give up arguing!" Um. No.
Whilst we agree that only the release root should (or in some cases can) be
checked out, from there we differ. My point of view is that looking for the SCM
section/how to check out/etc of a module is NOT a valid one, and we should
either:
a) remove it (as it's pointless) or,
b) point back to the release root.
As you have pointed out there are lots of different ways in which projects can
and are being setup and used. In my view, we can only help them so far. Having
a jnr dev look at a highly complex, non standard build is a tall order to start
with! And not one that we can necessarilly solve here. We seem to be tying
ourselves in knots over an edge case.
So I'm all for enforcer rules etc.
What do others have to say on the matter?
> SCM-link in site of multimodule projects should not append module name by
> default (at least for git)
> ----------------------------------------------------------------------------------------------------
>
> Key: MPIR-234
> URL: https://issues.apache.org/jira/browse/MPIR-234
> Project: Maven Project Info Reports Plugin
> Issue Type: Bug
> Components: scm
> Affects Versions: 2.4
> Reporter: Mirko Friedenhagen
>
> I have setup a simple multi module project (see
> https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
> which uses git on github as {{scm}}. While rendering the site, MPIR will by
> default add the name of the module to the SCM-URLs in source-repository.html.
> So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
> https://github.com/mfriedenhagen/multi-module-sample/core/,
> g...@github.com:mfriedenhagen/multi-module-sample.git/core and
> git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
> the core module. All these URLs are invalid. For SVN this could be assumed to
> be the right behaviour, for git and probably other SCMs this is not true. As
> a workaround I have to reconfigure the scm section (see
> https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
> in the modules like this:
> {code:xml}
> <scm>
> <connection>${project.parent.scm.connection}</connection>
>
> <developerConnection>${project.parent.scm.developerConnection}</developerConnection>
> <url>${project.parent.scm.url}</url>
> </scm>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
