[ 
https://issues.apache.org/jira/browse/MWAR-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MWAR-177.
-------------------------------
    Resolution: Auto Closed

This issue has been auto closed because it has been inactive for a long period 
of time. If you think this issue still applies, retest your problem with the 
most recent version of Maven and the affected component, reopen and post your 
results.

> Filtering failling should be configurable
> -----------------------------------------
>
>                 Key: MWAR-177
>                 URL: https://issues.apache.org/jira/browse/MWAR-177
>             Project: Maven WAR Plugin
>          Issue Type: Improvement
>          Components: filtering
>    Affects Versions: 2.1-alpha-2
>         Environment: Ubuntu 8.10 x64
> Java JDK 1.5
>            Reporter: Jorge Morales Pou
>
> When performing filtering, people usually have a filter override methodology, 
> where there is a default values in a filter file, and filters can be 
> overriden including a filter file in project wc.
> For example, I have this pom, for filtering my web.xml:
> {quote}
>       <plugin>
>         <!--  This plugin enables filtering of web.xml based on properties 
> defined in build.properties -->
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-war-plugin</artifactId>
>         <version>2.1-alpha-2</version>
>         <configuration>
>           <filters>
>             <filter>build.properties</filter>
>             <filter>build.default.properties</filter>
>           </filters>
>           
> <filteringDeploymentDescriptors>true</filteringDeploymentDescriptors>
>         </configuration>
>       </plugin>
> {quote}
> I only want to upload to my VCS the build.default.properties, for default 
> properties, and in my WC I want to have a build.properties, with overriden 
> properties. This file should be optional, and excluded from VCS. Now CI is 
> going to fail if this file doesn't exist, with such a message:
> {quote}
> [ERROR] fail to build filering wrappers Error loading property file 
> 'build.properties'
> [INFO] 
> ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Error loading property file 'build.properties'
> {quote}
> What I propose is issuing a warning if filter file is not present, on some 
> filter files, something like:
> {quote}
>       <plugin>
>         <!--  This plugin enables filtering of web.xml based on properties 
> defined in build.properties -->
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-war-plugin</artifactId>
>         <version>2.1-alpha-2</version>
>         <configuration>
>           <optionalFilters>
>             <optionalFilter>build.properties</optionalFilter>
>           </optionalFilters>
>           <filters>
>             <filter>build.default.properties</filter>
>           </filters>
>           
> <filteringDeploymentDescriptors>true</filteringDeploymentDescriptors>
>         </configuration>
>       </plugin>
> {quote}
> or something like:
> {quote}
>       <plugin>
>         <!--  This plugin enables filtering of web.xml based on properties 
> defined in build.properties -->
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-war-plugin</artifactId>
>         <version>2.1-alpha-2</version>
>         <configuration>
>           <failOnMissingFilter>false</failOnMissingFilter>
>           <filters>
>             <filter>build.properties</filter>
>             <filter>build.default.properties</filter>
>           </filters>
>           
> <filteringDeploymentDescriptors>true</filteringDeploymentDescriptors>
>         </configuration>
>       </plugin>
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to