[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733949#comment-14733949
 ] 

Michael Osipov commented on MCHECKSTYLE-307:
--------------------------------------------

After applying the PR to Checkstyle master and trying with 6.11-SNAPSHOT, all 
ITs pass except for MCHECKSTYLE-268. It seems like the Google checks have been 
expanded and there are three instead of two violations now. I will modify 
{{verify.groovy}} as soon as 6.11 is out.

> Upgrade to Checkstyle 6.10.1+
> -----------------------------
>
>                 Key: MCHECKSTYLE-307
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-307
>             Project: Maven Checkstyle Plugin
>          Issue Type: Task
>    Affects Versions: 2.16
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>
> Hi folks,
> I have upraded Checkstyle locally and almost all ITs pass except for the 
> issues [[email protected]] already has described:
> {quote}
> Changes in Checkstyle 6.3 that impact this plugin:
> * The IT MCHECKSTYLE-214-basedir-resource fails after upgrade to Checkstyle 
> 6.3 with NPE - I have not found a solution for this yet
> Changes in Checkstyle 6.6 that impact this plugin:
> * DefaultLogger( OutputStream, boolean ) now throws 
> UnsupportedEncodingException - this is easy to fix
> {quote}
> The first issue is caused because the default checkfiles apply to specific 
> file extensions now, so IT for MCHECKSTYLE-214. [~rfscholte], what do you 
> think about it. We can invert the test or add a custom {{sun_checks.xml}}.
> The second one can be fixed with the linked GH issue.
> I am willing to promote a release if I get some help to resolve the issues 
> above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to