[ 
https://issues.apache.org/jira/browse/MSITE-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952187#comment-14952187
 ] 

Hervé Boutemy commented on MSITE-750:
-------------------------------------

bug reproduced (yes, this is a bug, clearly)
executed with "-X" flag:
{noformat}[INFO] Parent project loaded from repository: 
com.mysite:mysite-parent:pom:1.0.0
[DEBUG] Mapped url: 
dav:https://nexus2.mysite.net:123/nexus/content/sites/site/mysite-child/2.0.0/ 
to relative path: 
../../../../../../../nexus2.mysite.net:123/nexus/content/sites/site/mysite-child/2.0.0
[DEBUG] top 
distributionManagement.site.url=dav:https://nexus1.mysite.net:123/nexus/content/sites/site/mysite-parent/1.0.0/,
 actual module relative path: 
../../../../../../../nexus2.mysite.net:123/nexus/content/sites/site/mysite-child/2.0.0{noformat}
comes from AbstractDeployMojo:
{code:java}    protected String getTopDistributionManagementSiteUrl()
        throws MojoExecutionException
    {
        if ( topDistributionManagementSiteUrl == null )
        {
            topDistributionManagementSiteUrl = 
determineTopDistributionManagementSiteUrl();

            getLog().debug( "top distributionManagement.site.url=" + 
topDistributionManagementSiteUrl
                                + ", actual module relative path: " + 
getDeployModuleDirectory() );
        }
        return topDistributionManagementSiteUrl;
    }

    protected String getDeployModuleDirectory()
        throws MojoExecutionException
    {
        String relative = siteTool.getRelativePath( getSite( project ).getUrl(),
                                                    
getTopDistributionManagementSiteUrl() );

        // SiteTool.getRelativePath() uses File.separatorChar,
        // so we need to convert '\' to '/' in order for the URL to be valid 
for Windows users
        relative = relative.replace( '\\', '/' );

        return ( "".equals( relative ) ) ? "./" : relative;
    }{code}

now looking into SiteTool 
http://maven.apache.org/doxia/doxia-tools/doxia-integration-tools/index.html


> site plugin 3.4 doesn't override correctly parent distributionManagement site 
> url with another one defined in child project
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MSITE-750
>                 URL: https://issues.apache.org/jira/browse/MSITE-750
>             Project: Maven Site Plugin
>          Issue Type: Bug
>          Components: site:deploy
>    Affects Versions: 3.4
>         Environment: maven 3.2.1, 3.2.3, 3.3.3, windows 7 professional
>            Reporter: Marat Saitov
>         Attachments: maven-site-plugin-example.zip
>
>
> site plugin 3.4 doesn't override correctly parent distributionManagement site 
> url (absolute url) with different absolute url defined in child project.
> parent project
> {code:xml}
>       <groupId>com.mysite</groupId>
>       <artifactId>mysite-parent</artifactId>
>       <version>1.0.0</version>
>       <packaging>pom</packaging>
>       <properties>
>               
> <siteDistribution.nexusId>mysite-nexus1-repositories</siteDistribution.nexusId>
>               
> <siteDistribution.nexusUrl>dav:https://nexus1.mysite.net:123/nexus/content/sites/site/${project.artifactId}/${project.version}/</siteDistribution.nexusUrl>
>       </properties>
>       <distributionManagement>
>               <site>
>                       <id>${siteDistribution.nexusId}</id>
>                       <url>${siteDistribution.nexusUrl}</url>
>               </site>
>       </distributionManagement>
> {code}
> child project
> {code:xml}
>       <parent>
>               <groupId>com.mysite</groupId>
>               <artifactId>mysite-parent</artifactId>
>               <version>1.0.0</version>
>       </parent>
>       <artifactId>mysite-child</artifactId>
>       <version>2.0.0</version>
>       <packaging>content-package</packaging>
>       <properties>
>               
> <siteDistribution.nexusId2>mysite-nexus2-repositories</siteDistribution.nexusId2>
>               
> <siteDistribution.nexusUrl2>dav:https://nexus2.mysite.net:123/nexus/content/sites/site/${project.artifactId}/${project.version}/</siteDistribution.nexusUrl2>
>       </properties>
>       <distributionManagement>
>               <site>
>                       <id>${siteDistribution.nexusId2}</id>
>                       <url>${siteDistribution.nexusUrl2}</url>
>               </site>
>       </distributionManagement>
> {code}
> The error is that in case if we defined another absolute path in the 
> "distributionManagement.site.url" with different domain in the CHILD project 
> the maven site plugin tries to generate a relative path to the url defined in 
> the "distributionManagement.site.url" in the PARENTproject.
> But I expected that the absolute url defined in the  
> "distributionManagement.site.url" in the CHILD project just will be used by 
> maven-site-plugin without transformation like this
> {code}
> [INFO] --- maven-site-plugin:3.4:deploy (default-deploy) @ mysite-child ---
> https://nexus1.mysite.net:123/nexus/content/sites/site/mysite-parent/1.0.0/ - 
> Session: Opened  
> [INFO] Pushing C:\devs\mysite-child\target\site
> [INFO]    >>> to 
> https://nexus1.mysite.net:123/nexus/content/sites/site/mysite-parent/1.0.0/../../../../../../../nexus2.mysite.net:123/nexus/content/sites/site/mysite-child/2.0.0
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to