[
https://issues.apache.org/jira/browse/WAGON-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953127#comment-14953127
]
Per Landberg commented on WAGON-446:
------------------------------------
Sure, but...
As I see it, there are two approaches to solving this:
1) Remove the fallback behavior of ScpHelper.getPrivateKey(). This is IMHO the
correct solution but it will change the semantic of using wagon-ssh and
wagon-ssh-external to always require an explicit privateKey.
2) Try to expand the condition when to use the returned privateKey in
AbstractJschWagon, by for example, only use the key if a password is also given
and not running interactivly. It will certainly work for this issue but it may
introduce other problems for other uses-cases.
If you give me a hint of which solution you prefer, I will try to create a
patch.
BTW, would a github pull request work as well? Maybe that would be a better
forum for discussion which solution is correct?
> SSH agent authentication is no longer working in wagon-ssh 2.10
> ---------------------------------------------------------------
>
> Key: WAGON-446
> URL: https://issues.apache.org/jira/browse/WAGON-446
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-ssh
> Affects Versions: 2.10
> Reporter: Per Landberg
> Assignee: Dan Tran
>
> After upgrading to wagon-2.10, SSH Agent authentication doesn't seems to
> work anymore. I got the following error when trying to publish a site, using
> maven-site-plugin 3.4:
> Using private key: <PATH TO id_rsa>
> : Error uploading site: Cannot connect. Reason: Auth fail -> [Help 1]
> I have no server for this site defined in my settings.xml
> After some investigation, I suspect that the cause is WAGON-413 since the
> logic in AbstractJschWagon was changed to not use the agent if
> ScpHelper.getPrivateKey() returns a File.
> Unfortunate, ScpHelper.getPrivateKey() seems to have a fallback behavior that
> always returns the id_rsa key (if one exists) even when no matching server
> element exists in settings.xml and the effect is that the agent is never
> consulted.
> The authentication will then fail since no server element provides a key
> password.
> My current workaround is to set the wagon.privateKeyDirectory System Property
> to an empty directory. This will prevent the ScpHelper.getPrivateKey()
> fallback to kick in.
> Has anybody else got SSH agent working in combination with existing id_rsa
> files?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
