[jira] [Commented] (MSHADE-172) "java.lang.ArithmeticException: / by zero" in MinijarFilter

[Michael Dabney (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MSHADE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957189#comment-14957189
 ] 

Michael Dabney commented on MSHADE-172:
---------------------------------------

Actually, it appears that the logic in the fix commited in r1682566 is reversed:

{code:title=MinijarFilter.java - Line 223-234|borderStyle=solid}
        if ( classesTotal == 0 )
        {
            log.info( "Minimized " + classesTotal + " -> " + classesKept + " (" 
+ 100 * classesKept / classesTotal
                + "%)" );
        }
        else
        {
            log.info( "Minimized " + classesTotal + " -> " + classesKept );
        }
{code}

That should be {{if ( classesTotal != 0 )}}

> "java.lang.ArithmeticException: / by zero" in MinijarFilter
> -----------------------------------------------------------
>
>                 Key: MSHADE-172
>                 URL: https://issues.apache.org/jira/browse/MSHADE-172
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Jon McLean
>            Assignee: Karl Heinz Marbaise
>            Priority: Trivial
>             Fix For: 2.4
>
>
> When classesTotal == 0 then the following generates an error:
> {code:java}
> log.info( "Minimized " + classesTotal + " -> " + classesKept + " (" + 100 * 
> classesKept / classesTotal + "%)" );
> {code}
> An IF conditional should be added so that this error is handled gracefully
> {code:java}
> if(classesTotal != 0) {
>      log.info( "Minimized " + classesTotal + " -> " + classesKept + " (" + 
> 100 * classesKept / classesTotal + "%)" );
> } else {
>     log.info( "Minimized " + classesTotal + " -> " + classesKept);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)