[
https://issues.apache.org/jira/browse/SUREFIRE-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031184#comment-15031184
]
ASF GitHub Bot commented on SUREFIRE-1194:
------------------------------------------
Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/107#issuecomment-160474911
Current status:
5.14.3
-------
The jar is still available:
https://github.com/cbeust/testng/blob/master/lib-supplied/guice-2.0.jar
It's a shaded jar of Guice 2.0 with custom package. Its usage was removed
in 5.14.6 with
https://github.com/cbeust/testng/commit/331ab5267015b500bd06204f8c2c9cde40dc2e40
> We can add system-dependency to the pom.xml of IT
I think the pom will still be wrong for 5.14.3 and maven will ignore
transitive dependencies.
It could work for 5.14.4 and 5.14.5, but the 5.14.4 test seems to work
without this jar.
> you can of course ask Cedric how the users use to struggle with this
problem.
I supposed they don't: 5.14.6 and later replaced previous 5.14.x, and there
is no more support on so old versions.
But maybe @cbeust can tell us the story of this shaded jar :)
5.13 & 5.14.2
-------
Fun part for the listener attribute:
* Before -> ?
* 5.12.1 -> List<Class>
* 5.13 / 5.13.1 / 5.14 -> String
* 5.14.1 / 5.14.2 -> List
* 5.14.3 until now -> Both (String or List) is possible
But, even fixed, there is an issue in TestNG with listener:
Join on `<space>` ->
https://github.com/cbeust/testng/blob/testng-5.14.2/src/main/java/org/testng/TestNG.java#L1313
And split on `,` or `;` ->
https://github.com/cbeust/testng/blob/testng-5.14.2/src/main/java/org/testng/TestNG.java#L1178
Fixed with 5.14.3
> reporter argument does not work for TestNG
> ------------------------------------------
>
> Key: SUREFIRE-1194
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1194
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.19
> Reporter: Testo Nakada
> Assignee: Tibor Digana
> Fix For: 2.19.1
>
>
> TestNG plugin seems to map -reporter command line parameter to reporterslist
> which was removed in TestNG project since 2010
> (a4779524b59330e98ee596c5faa43ae1b33ff844). Therefore, this configuration has
> stopped working since then. The configuration mentioned in
> http://maven.apache.org/surefire/maven-surefire-plugin/examples/testng.html#Using_Custom_Listeners_and_Reporters
> does not work as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
