[ 
https://issues.apache.org/jira/browse/MPMD-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034233#comment-15034233
 ] 

ASF GitHub Bot commented on MPMD-186:
-------------------------------------

GitHub user gyrfalcon opened a pull request:

    https://github.com/apache/maven-plugins/pull/71

    [MPMD-186] Fix Windows-Specific Constants

    Fixed a defect that caused certain PMD Violations to not be excluded
    correctly on non-Windows computers.
    
    See https://issues.apache.org/jira/browse/MPMD-186

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gyrfalcon/maven-plugins MPMD-186

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-plugins/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #71
    
----
commit 717219f228e76de2f101120e21868ce1809569bc
Author: Justin Shepard <[email protected]>
Date:   2015-12-01T18:03:16Z

    [MPMD-186] Fix Windows-Specific Constants
    
    Fixed a defect that caused certain PMD Violations to not be excluded
    correctly on non-Windows computers.
    
    See https://issues.apache.org/jira/browse/MPMD-186

----


> Class Name with slash is omitted from exclusions on pmd:check
> -------------------------------------------------------------
>
>                 Key: MPMD-186
>                 URL: https://issues.apache.org/jira/browse/MPMD-186
>             Project: Maven PMD Plugin
>          Issue Type: Bug
>          Components: PMD
>    Affects Versions: 3.1
>         Environment: Ubuntu 13.04  Jdk 1.7  Maven 3.1.1
>            Reporter: Diego Almeida
>            Priority: Critical
>         Attachments: maven-pmd-plugin.patch
>
>
> The method getFileName on class Violation returns the class name with slash 
> or back slash. On the method extractClassName in the Class 
> PmdViolationCheckMojo the backslashes are replaced with dots in order to 
> compose the package name, but some
>  classes do not meet this condition and stay with the original class name and 
> are not found on the map excludeFromFailureClasses that contains the classes 
> and the rules with exceptions.
> This generates an error even if the class and the rule are included on the 
> exception file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to