[
https://issues.apache.org/jira/browse/MNG-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043238#comment-15043238
]
Hervé Boutemy commented on MNG-5719:
------------------------------------
I had a look at the code, and I don't understand what is expected from testing
the class type, since we already know that it's a jdk that was requested, and
there is no real use of the JavaToolchain API (since it's empty currently:
that's why I didn't fear beaking API now, before adding public API)
Then I think that you should simply remove this useless check.
Or if you really want to do a check (there was MNG-5716 where a wrong type
could be returned), check it with "jdk".equals(tc.getType()): yes, less object
oriented, but will give same result without relying on this changing API
> rename JavaToolChain to JavaToolchain for consistency and don't declare it as
> Plexus component
> ----------------------------------------------------------------------------------------------
>
> Key: MNG-5719
> URL: https://issues.apache.org/jira/browse/MNG-5719
> Project: Maven
> Issue Type: Wish
> Components: Toolchains
> Affects Versions: 3.2.3
> Reporter: Hervé Boutemy
> Assignee: Hervé Boutemy
> Fix For: 3.2.5
>
>
> since these classes are not used directly, this should not cause any harm
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
