[ 
https://issues.apache.org/jira/browse/SUREFIRE-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059338#comment-15059338
 ] 

ASF GitHub Bot commented on SUREFIRE-1135:
------------------------------------------

Github user Tibor17 commented on the pull request:

    https://github.com/apache/maven-surefire/pull/79#issuecomment-164962324
  
    @agudian 
    I would prefer using only message from Exception in the callback method 
`onTestSkipped()`.
    WDYT? 
    My only problem is the influence in test report. The skipped-test event 
appeared in test report should not be considered as an error while having stack 
trace.
    I would like to modify this PR and push to master without stack trace. 
Let's see if users are shouting for this feature in Jira. I agree with this PR 
that the message taken from Exception would improve lookup for details in the 
report.


> Improve ignore message for TestNG
> ---------------------------------
>
>                 Key: SUREFIRE-1135
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1135
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: TestNG support
>            Reporter: Michal Bocek
>            Assignee: Tibor Digana
>         Attachments: TEST-testng.SkipExceptionReportTest.xml
>
>
> Once the test is ignored/skipped in TestNG no additional informations are 
> reported. Surefire xml report contains only "skipped" element  without any 
> information. It will be very useful to provide addition info like message and 
> stacktrace. 
> JUnit reporter correctly provide ignore message from "Ignore" annotation so 
> we can similarly provide message from SkipException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to