[
https://issues.apache.org/jira/browse/MNG-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076215#comment-15076215
]
ASF GitHub Bot commented on MNG-5956:
-------------------------------------
GitHub user nhojpatrick opened a pull request:
https://github.com/apache/maven/pull/75
Patch for MNG-5956
Issue raised https://issues.apache.org/jira/browse/MNG-5956
If you use modules, and that results in the same project/pom being included
multiple times then an exception is thrown. But as it's the exact same
project/pom it can simple be ignore in my view.
Simple project structure;
./pom.xml
./common/pom.xml
./sub1/pom.xml
./sub2/pom.xml
If sub1 has nested modules but for some reason common should 50% of the
time be rebuilded if sub1 i rebuilt then adding ../common aids developers.
if sub2 has a similar setup to sub2, then when you build at the root
directory an error is produces as both sub1 and sub2 reference common.
This pull request should ignore where the project is an exact match of the
same physical pom.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nhojpatrick/maven
bugfix/MNG-5956-invalid-DuplicateProjectException
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 9e22e8abaae25d7f2aace7a505ca1fbc625f5c6a
Author: John Patrick <[email protected]>
Date: 2016-01-01T01:42:22Z
Patch for MNG-5956
----
> Invalid DuplicateProjectException if physically same pom.xml
> ------------------------------------------------------------
>
> Key: MNG-5956
> URL: https://issues.apache.org/jira/browse/MNG-5956
> Project: Maven
> Issue Type: Bug
> Components: core
> Affects Versions: 3.2.x
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00)
> Maven home: /opt/local/share/java/maven3
> Java version: 1.8.0_60, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.2", arch: "x86_64", family: "mac"
> Reporter: John Patrick
> Labels: github-import, newbie, patch
>
> Several projects I've worked on have lots of modules, some to aid developers
> sub modules have been hijacked to also build other projects. Take the
> following example.
> ./pom.xml
> ./common/pom.xml
> ./sub1/pom.xml
> ./sub2/pom.xml
> If sub1 and sub2 both include <module>../common</module> then
> DuplicateProjectException is thrown. I've created a patch which before
> throwing the exception does one last check to ignore instances where the
> clash is actually the same physical pom file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
