[ 
https://issues.apache.org/jira/browse/SUREFIRE-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124500#comment-15124500
 ] 

Michael Osipov commented on SUREFIRE-1137:
------------------------------------------

[~agudian], just checked the Git diff for the commit while working on 
SUREFIRE-1220 and this is very good work but why did you introduce 
{{FORK_STREAM_CHARSET_NAME}} with {{ISO-8859-1}}? The interal string utils do 
align all {{stdout}} output to 7-bit ASCII and {{executeCommandLineAsCallable}} 
does not even pass that {{Charset}} to the created {{StreamPumpers}}. In theory 
this could create incorrectly or even unmappable input? Moreover, in some 
places a {{char}} is properly 7-bit aligned and {{ReportEntries}} are passed 
and aligned too. Everything is aligned with {{escapeToPrintable}} or 
{{escapeBytesToPrintable}}. I'd be happy to receive an explanation on this!

> Problem with Umlauts in stdout
> ------------------------------
>
>                 Key: SUREFIRE-1137
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1137
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.18
>         Environment: Linux
>            Reporter: Jürgen Zeller
>            Assignee: Andreas Gudian
>             Fix For: 2.19
>
>         Attachments: TEST-eu.jzeller.AppTest.xml, surefire-test.zip, 
> surefire-test.zip
>
>
> When using Cp1252 as file encoding, the generated Surefire stdout report 
> contains invalid characters when run on Linux. When running the same test on 
> Windows, everything is fine.
> A simular Problem was reported in SUREFIRE-998



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to