Karl Heinz Marbaise created MSHARED-495:
-------------------------------------------

             Summary: Add convenience method to move code into Maven Filtering
                 Key: MSHARED-495
                 URL: https://issues.apache.org/jira/browse/MSHARED-495
             Project: Maven Shared Components
          Issue Type: Improvement
            Reporter: Karl Heinz Marbaise
            Priority: Minor


A few plugins contain the following code which belong into maven-filtering 
instead:
{code:java}
        if ( delimiters != null && !delimiters.isEmpty() )
        {
            LinkedHashSet<String> delims = new LinkedHashSet<String>();
            if ( useDefaultDelimiters )
            {
                delims.addAll( this.getDelimiters() );
            }

            for ( String delim : delimiters )
            {
                if ( delim == null )
                {
                    // FIXME: ${filter:*} could also trigger this condition. 
Need a better long-term solution.
                    delims.add( "${*}" );
                }
                else
                {
                    delims.add( delim );
                }
            }

            this.setDelimiters( delims );
{code}
Moving this code into maven-fitlering where it belongs. New method introduced:
{code:java}
setDelimiters( LinkedHashSet<String> delimiters, boolean useDefaultDelimiters )
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to