[
https://issues.apache.org/jira/browse/MSHARED-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136660#comment-15136660
]
Karl Heinz Marbaise edited comment on MSHARED-495 at 2/8/16 7:21 AM:
---------------------------------------------------------------------
This is a compatible change to maven-filtering 3.0.0 but adding new
functionality. So we need to go for {{maven-filtering-3.1.0}}
was (Author: khmarbaise):
This is a compatible change to maven-filtering 3.0.0 but adding new
functionality. So we need to go for {maven-filtering-3.1.0}
> Add convenience method to move code into Maven Filtering
> --------------------------------------------------------
>
> Key: MSHARED-495
> URL: https://issues.apache.org/jira/browse/MSHARED-495
> Project: Maven Shared Components
> Issue Type: Improvement
> Affects Versions: maven-filtering-3.0.0
> Reporter: Karl Heinz Marbaise
> Priority: Minor
> Fix For: maven-filtering-3.0.1
>
>
> A few plugins contain the following code which belong into maven-filtering
> instead:
> {code:java}
> if ( delimiters != null && !delimiters.isEmpty() )
> {
> LinkedHashSet<String> delims = new LinkedHashSet<String>();
> if ( useDefaultDelimiters )
> {
> delims.addAll( this.getDelimiters() );
> }
> for ( String delim : delimiters )
> {
> if ( delim == null )
> {
> // FIXME: ${filter:*} could also trigger this condition.
> Need a better long-term solution.
> delims.add( "${*}" );
> }
> else
> {
> delims.add( delim );
> }
> }
> this.setDelimiters( delims );
> {code}
> Moving this code into maven-fitlering where it belongs. New method introduced:
> {code:java}
> setDelimiters( LinkedHashSet<String> delimiters, boolean useDefaultDelimiters
> )
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
