[ 
https://issues.apache.org/jira/browse/MWAR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MWAR-150.
------------------------------------
    Resolution: Implemented

> Test for overlay.skip before resolving overlay dependency
> ---------------------------------------------------------
>
>                 Key: MWAR-150
>                 URL: https://issues.apache.org/jira/browse/MWAR-150
>             Project: Maven WAR Plugin
>          Issue Type: Improvement
>          Components: overlay
>    Affects Versions: 2.1-alpha-1
>            Reporter: Mike Youngstrom
>         Attachments: skip-overlay.zip
>
>
> I have a "master" pom that many projects share and inherit common build, 
> report, dependency, etc. functionality from.  I would like all of my .war 
> projects to inherit from this "master" pom including my overlays and my 
> projects that use the overlay.
> In my master pom I have:
> {code:xml}
>               <pluginManagement>
>                       <plugins>
>                               <plugin>
>                                       
> <groupId>org.apache.maven.plugins</groupId>
>                                       
> <artifactId>maven-war-plugin</artifactId>
>                                       <version>2.1-alpha-1</version>
>                                       <configuration>
>                                               <overlays>
>                                                       <overlay>
>                                                               
> <groupId>com.mycompany.app</groupId>
>                                                               
> <artifactId>my-overlay</artifactId>
>                                                       </overlay>
>                                                       <overlay></overlay>
>                                               </overlays>
>                                       </configuration>
>                               </plugin>
>                       </plugins>
>               </pluginManagement>
> {code}
> This obviously causes a problem when the overlay war is created because it 
> cannot overlay itself with itself.  So I get the error:
> {noformat}
> "overlay[ id com.mycompany.app:my-overlay] is not a dependency of the 
> project."
> {noformat}
> I tried overriding the war plugin in the overlay pom and removed the overlays 
> but there seemed to be some kind of inheritance thing going on where the 
> overlays were still being added no matter what I did.  (Might be a different 
> issue?)
> Anyway, another way to fix this issue might be to use the "skip" attribute??? 
>  But I get the same error using {{<skip>true</skip>}}.  Would it be possible 
> to allow the "skip" attribute to be tested prior to overlay dependency 
> checking?  I've provided an example project of how I would like skip to 
> function in a clean way that might help this problem of circular overlays.
> Mike



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to