[ 
https://issues.apache.org/jira/browse/MNG-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150873#comment-15150873
 ] 

Christian Schulte edited comment on MNG-5971 at 2/17/16 6:04 PM:
-----------------------------------------------------------------

Please take a look at [DefaultModelBuilder around line 376 to 
409|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java;h=d42bfddf88c7f205dbe037f2217c590202a490d5;hb=HEAD#l376].
 As I understand the issue, you want the  
[import|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java;h=d42bfddf88c7f205dbe037f2217c590202a490d5;hb=HEAD#l454]
 to be performed into the intermediate model (included where it is declared) so 
that those imported values are available to inheritance processing. Did I get 
that correctly?

I looked at 
[spring-boot-dependencies-1.3.2.RELEASE.pom|http://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-dependencies/1.3.2.RELEASE/spring-boot-dependencies-1.3.2.RELEASE.pom]
 and 
[spring-boot-starter-parent-1.3.2.RELEASE.pom|http://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-starter-parent/1.3.2.RELEASE/spring-boot-starter-parent-1.3.2.RELEASE.pom].
 The issue is not present in there, right?


was (Author: schulte77):
Please take a look at [DefaultModelBuilder around line 376 to 
409|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java;h=d42bfddf88c7f205dbe037f2217c590202a490d5;hb=HEAD#l376].
 As I understand the issue, you want the  
[import|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java;h=d42bfddf88c7f205dbe037f2217c590202a490d5;hb=HEAD#l454]
 to be performed into the intermediate model (included where it is declared) so 
that those imported values are available to inheritance processing. Did I get 
that correctly?

> Dependency management in a child project cannot override a version using a BOM
> ------------------------------------------------------------------------------
>
>                 Key: MNG-5971
>                 URL: https://issues.apache.org/jira/browse/MNG-5971
>             Project: Maven
>          Issue Type: Wish
>          Components: Dependencies
>    Affects Versions: 3.3.3
>            Reporter: Stephane Nicoll
>            Priority: Trivial
>              Labels: close-pending
>
> When a project extends from a parent with a {{dependencyManagement}} section, 
> it is not always possible to properly override (and align) the version to use 
> for a group of dependencies.
> We typically use Bill Of Materials to gather a group of modules and make sure 
> their versions are consistent. 
> The following project demonstrates the issue: 
> https://github.com/snicoll-scratches/maven-dependency-management
> The first commit is a working use case where the parent uses a bom with 
> version A and we use the same bom with version B in the child. Version B is 
> used as expected.
> The second commit demonstrates the faulty scenario. Rather than using a bom 
> in the parent, we use a direct dependency (provided by that bom). We still 
> use the bom with a different version. In that case all the dependencies but 
> the one provided by the parent are overridden (leading to mixed versions for 
> the dependencies provided by the BOM).
> It looks like the distance is still used to compute the version while the 
> graph of dependencies should be flatten at each step for a proper override. 
> Thoughts? Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to