[
https://issues.apache.org/jira/browse/WAGON-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151454#comment-15151454
]
ASF GitHub Bot commented on WAGON-451:
--------------------------------------
GitHub user hyPiRion opened a pull request:
https://github.com/apache/maven-wagon/pull/23
[WAGON-451] Accept NO CONTENT in resourceExists
Some maven repositories may respond with 204 NO CONTENT instead of 200 OK
when sending in HTTP HEAD requests. This throws an exception in wagon-http and
wagon-http-lightweight.
This patch makes 204 NO CONTENT responses from HTTP HEAD requests in
wagon-http and wagon-http-lightweight return true in `resourceExists`, instead
of throwing an exception.
The patch also adds makes wagon-http-lightweight accept 304 NOT MODIFIED,
to make it consistent with the wagon-http implementation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyPiRion/maven-wagon WAGON-451
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-wagon/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 1e8c1a6b8be4c002cceda1dd2e37e4ff432f20ab
Author: Jean Niklas L'orange <[email protected]>
Date: 2016-02-17T23:42:00Z
[WAGON-451] Accept NO CONTENT in resourceExists
This patch makes 204 NO CONTENT responses from HTTP HEAD requests in
wagon-http and wagon-http-lightweight return true in `resourceExists`,
instead of throwing an exception.
The patch also adds makes wagon-http-lightweight accept 304 NOT
MODIFIED, to make it consistent with the wagon-http implementation.
----
> wagon-http does not handle 204 as success for HEAD requests
> -----------------------------------------------------------
>
> Key: WAGON-451
> URL: https://issues.apache.org/jira/browse/WAGON-451
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-http, wagon-http-lightweight
> Affects Versions: 2.10
> Environment: maven-wagon 0.2.10
> Reporter: Jean Niklas L'orange
> Priority: Minor
>
> This seems to similar to WAGON-124.
> Some maven repositories may respond with 204 no content for http HEAD
> requests. In those cases, wagon-http and wagon-http-lightweight will throw an
> exception instead of accepting it as if it was a 200 OK request.
> For a real life example of this, see
> https://github.com/technomancy/leiningen/issues/2093
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
