[
https://issues.apache.org/jira/browse/SUREFIRE-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301137#comment-15301137
]
ASF GitHub Bot commented on SUREFIRE-1250:
------------------------------------------
Github user kgyrtkirk commented on the pull request:
https://github.com/apache/maven-surefire/pull/113#issuecomment-221739676
I've used `Pattern.compile` to keep the regexp's problem description; i
thinked it makes it more clear how it will be used eventually.
I picked `TestListResolver` as it's place; because this is the first point
where the deconstruction logic is used.
plus: I wanted to keep all the generic exceptions of Pattern prior to these
construction exceptions - without reassembling the original regex - but maybe
this dosen't matter.
I might be able to move it to `ResolvedTest`...tomorrow i will look at it.
> Regex testcase filtering: exception when hashmark is regex-quoted
> -----------------------------------------------------------------
>
> Key: SUREFIRE-1250
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1250
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
> Affects Versions: 2.19.1
> Reporter: Zoltan Haindrich
> Assignee: Tibor Digana
> Priority: Minor
> Attachments: SUREFIRE-1250.patch
>
>
> i've been using regex to select which tests to run...and i've got some wierd
> exceptions when executing
> {code}
> mvn test "-Dtest=%regex[.*\Q#\E.*]"
> {code}
> executing the above command results in:
> {code}
> java.util.regex.PatternSyntaxException:
> Illegal/unsupported escape sequence near index 1
> \E.*
> ^
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> {code}
> i noticed earlier that maven might do some black-magic with these regexps in
> the background ( i know that it should know the class name earlier; to avoid
> starting testcases which will get entirely excluded...and thats cool )
> ...so..i assume maven does split the regex by the {{#}}; and that's okay - if
> that can't be avoided; place some pointers in the documentation about it
> and/or a more descriptive exception could be useful
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
