[ 
https://issues.apache.org/jira/browse/SUREFIRE-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15520802#comment-15520802
 ] 

Hervé Boutemy edited comment on SUREFIRE-683 at 9/25/16 1:12 PM:
-----------------------------------------------------------------

the way it is explained, I see "hard-coding some specific cases", then I don't 
like it this way

but yes, we can improve the reporting mecanism if we need: maven-reporting-exec 
is responsible of preparing reporting plugins
I suppose it could inject a parameter telling that jxr will be run, then the 
plugin can count on it, even if jxr hasn't been run yet
Or even more generic: I suppose we could inject the list of reports

Notice: since the report has to be able to run as a normal plugin, not during 
site generation, this may be problematic

perhaps we could make some code from maven-reporting-exec public, to be able to 
read reporting section of MavenProject

(notice I changed the issue type from bug to improvement: this is not really a 
bug)
(notice 2: the comment "As there's no reliable order for the report plugin 
execution" is wrong, there is reliable order for report plugins execution, it 
is just hard to explain when inheritance is at play and you want to insert a 
plugin somewhere else than after everything else)


was (Author: hboutemy):
the way it is explained, I see "hard-coding some specific cases", then I don't 
like it this way

but yes, we can improve the reporting mecanism if we need: maven-reporting-exec 
is responsible of preparing reporting plugins
I suppose it could inject a parameter telling that jxr will be run, then the 
plugin can count on it, even if jxr hasn't been run yet
Or even more generic: I suppose we could inject the list of reports

Notice: since the report has to be able to run as a normal plugin, not during 
site generation, this may be problematic

perhaps we could make some code from maven-reporting-exec public, to be able to 
read reporting section of MavenProject

(notice I changed the issue type from bug to improvement: this is not really a 
bug)

> Xref link generation regression with Maven 3
> --------------------------------------------
>
>                 Key: SUREFIRE-683
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-683
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Surefire Report Plugin
>    Affects Versions: 2.7.1
>         Environment: Apache Maven 3.0.1 (r1038046; 2010-11-23 11:58:32+0100)
> Java version: 1.6.0_20
> Java home: /usr/lib/jvm/java-6-openjdk/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux" version: "2.6.32-27-generic" arch: "i386" Family: "unix"
>            Reporter: Marc Rohlfs
>            Priority: Minor
>         Attachments: SUREFIRE-683_sample.zip
>
>
> When the site reports are created with Maven 3, the this plugin doesn't 
> generate the links to the Source Xref pages, when the JXR Plugin hasn't been 
> executed before.
> The plugin looks for the xrefLocation directory and if it doesn't exist, it 
> checks if the JXR plugin is configured for the project (see 
> http://maven.apache.org/plugins/maven-surefire-report-plugin/xref/org/apache/maven/plugins/surefire/report/SurefireReportMojo.html#203).
>  To properly generate the Xref links when the report is created with Maven 3, 
> the plugin should also check the reportPlugins paramerter of the Site plugin 
> configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to