[
https://issues.apache.org/jira/browse/SUREFIRE-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563837#comment-15563837
]
ASF GitHub Bot commented on SUREFIRE-1293:
------------------------------------------
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82699403
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullConsoleOutputReceiver.java
---
@@ -31,7 +31,13 @@
implements TestcycleConsoleOutputReceiver
{
- public void testSetStarting( ReportEntry reportEntry )
+ static final NullConsoleOutputReceiver INSTANCE = new
NullConsoleOutputReceiver();
+
+ private NullConsoleOutputReceiver()
+ {
+ }
+
+ public void testSetStarting(ReportEntry reportEntry )
--- End diff --
here is checkstyle error
> Simplify org.apache.maven.plugin.surefire.report.TestSetRunListener by using
> the null object pattern
> ----------------------------------------------------------------------------------------------------
>
> Key: SUREFIRE-1293
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1293
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Plugin
> Reporter: Benedikt Ritter
> Labels: github
> Fix For: 2.19.2
>
>
> The class org.apache.maven.plugin.surefire.report.TestSetRunListener has a
> lot of checks like this:
> {code:java}
> if( field != null )
> {
> // do something with field
> }
> {code}
> This can be simplified by providing fallback implementations for the fields
> being used by TestSetRunListener.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
