[
https://issues.apache.org/jira/browse/SUREFIRE-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687740#comment-15687740
]
ASF GitHub Bot commented on SUREFIRE-1306:
------------------------------------------
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/132
SUREFIRE-1306: JUnit4RerunFailingTestsIT does not execute with the JUnit
version configured in the test
Drop the junitVersion property from pom.xml and let the test execute
with the latest JUnit 4.12 currently available.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven-surefire SUREFIRE-1306
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #132
----
commit 02b6cdb4ee4aa1cbf8c4b300771979d40622781f
Author: Benedikt Ritter <[email protected]>
Date: 2016-11-22T20:05:13Z
SUREFIRE-1306: JUnit4RerunFailingTestsIT does not execute with the JUnit
version configured in the test
Drop the junitVersion property from pom.xml and let the test execute
with the latest JUnit 4.12 currently available.
----
> JUnit4RerunFailingTestsIT does not execute with the JUnit version configured
> in the test
> ----------------------------------------------------------------------------------------
>
> Key: SUREFIRE-1306
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1306
> Project: Maven Surefire
> Issue Type: Test
> Reporter: Benedikt Ritter
> Assignee: Tibor Digana
>
> All the test methods in JUnit4RerunFailingTestsIT set JUnit Version
> explicitly to 4.7 by calling {{setJUnitVersion( "4.7" )}}. This will in turn
> set the system property {{junit.version}}. The problem with this is, that the
> pom.xml in the test project (junit4-rerun-failing-tests) uses the property
> {{junitVersion}} instead. The version is set to 4.4 in pom.xml. Furthermore
> using JUnit 4.7 version in pom.xml results in test failures.
> Suggested solution: Drop the {{junitVersion}} property from pom.xml and use
> {{junit.version}} instead, making it possible to set the version from the
> test cases. Use version 4.12, since there seems to be a regression in 4.7
> causing the test to fail with this version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
