Ian Springer created MSHADE-248:
-----------------------------------

             Summary: shading fails with "error in opening zip file" if 
createSourcesJar=true and an invalid sources jar file is encountered
                 Key: MSHADE-248
                 URL: https://issues.apache.org/jira/browse/MSHADE-248
             Project: Maven Shade Plugin
          Issue Type: Bug
    Affects Versions: 2.4.3
            Reporter: Ian Springer


{code}
Downloading: 
https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
[WARNING] Checksum validation failed, expected <!DOCTYPE but is 
b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for 
https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
Could not validate integrity of download from 
https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
 Checksum validation failed, expected <!DOCTYPE but is 
b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
[WARNING] Checksum validation failed, expected <!DOCTYPE but is 
b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for 
https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
Downloaded: 
https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
 (2 KB at 1.3 KB/sec)
{code}

And then:

{code}
------------------------------------------------------------------------
BUILD FAILURE
------------------------------------------------------------------------
Total time: 18.486 s
Finished at: 2017-02-07T11:13:11-05:00
Final Memory: 72M/977M
------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project 
jclouds-shaded: Error creating shaded jar: error in opening zip file 
/Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar -> 
[Help 1]
{code}

bsh is a transitive dep of one of the jars I am shading. Since I can't control 
the fact that they have an invalid sources jar published, the shade plugin 
should be more forgiving and just log a warning and skip the bsh sources jar 
when building the shaded sources jar.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to