[
https://issues.apache.org/jira/browse/MNG-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952617#comment-15952617
]
Karl Heinz Marbaise edited comment on MNG-6203 at 4/2/17 10:26 AM:
-------------------------------------------------------------------
Hm..
{code:java}
private MavenExecutionRequest populateRequest( CliRequest cliRequest,
MavenExecutionRequest request )
{
.
.
.
String alternatePomFile = null;
if ( commandLine.hasOption( CLIManager.ALTERNATE_POM_FILE ) )
{
alternatePomFile = commandLine.getOptionValue(
CLIManager.ALTERNATE_POM_FILE );
}
File userToolchainsFile;
if ( commandLine.hasOption( CLIManager.ALTERNATE_USER_TOOLCHAINS ) )
{
userToolchainsFile = new File( commandLine.getOptionValue(
CLIManager.ALTERNATE_USER_TOOLCHAINS ) );
userToolchainsFile = resolveFile( userToolchainsFile,
workingDirectory );
}
else
{
userToolchainsFile = MavenCli.DEFAULT_USER_TOOLCHAINS_FILE;
}
...
{code}
This really looks like unnecessary code...cause it's not referenced anywhere
else in this method...
was (Author: khmarbaise):
Hm..
{code:java}
private MavenExecutionRequest populateRequest( CliRequest cliRequest,
MavenExecutionRequest request )
{
String alternatePomFile = null;
if ( commandLine.hasOption( CLIManager.ALTERNATE_POM_FILE ) )
{
alternatePomFile = commandLine.getOptionValue(
CLIManager.ALTERNATE_POM_FILE );
}
File userToolchainsFile;
if ( commandLine.hasOption( CLIManager.ALTERNATE_USER_TOOLCHAINS ) )
{
userToolchainsFile = new File( commandLine.getOptionValue(
CLIManager.ALTERNATE_USER_TOOLCHAINS ) );
userToolchainsFile = resolveFile( userToolchainsFile,
workingDirectory );
}
else
{
userToolchainsFile = MavenCli.DEFAULT_USER_TOOLCHAINS_FILE;
}
...
{code}
This really looks like unnecessary code...cause it's not referenced anywhere
else in this method...
> Minor cleanup in MavenCli.java
> ------------------------------
>
> Key: MNG-6203
> URL: https://issues.apache.org/jira/browse/MNG-6203
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
> Affects Versions: 3.5.0-beta-1
> Reporter: Stefan Eicher
> Priority: Trivial
> Attachments: Bildschirmfoto 2017-04-02 um 11.26.40.png,
> Bildschirmfoto 2017-04-02 um 11.37.41.png
>
>
> There seems to be some old unnecessary code in the MavenCli.java
> that could be cleaned up.
> I will create a pull-request.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
