[ 
https://issues.apache.org/jira/browse/SUREFIRE-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963116#comment-15963116
 ] 

Mikhail Stepura commented on SUREFIRE-1314:
-------------------------------------------

I don't see why that's a JUnit problem.  {{rerunFailingTestsCount}} is a 
functionality wich is specific to surefire, and JUnit has no idea about that.


The current implementation of 
{{JUnit4ProviderUtil#generateFailingTests(java.util.List<Failure>)}} filters 
out those failures with {{description.isTest() == false}}.  Which is the case 
both for a suite failure and a {{BeforeClass}} failure.
Also {{JUnit4ProviderUtil#cutTestClassAndMethod}} doesn't work with those 
descriptions, as they don't contain a method name.


> rerunFailingTestsCount doesn't work for errors in BeforeClass methods
> ---------------------------------------------------------------------
>
>                 Key: SUREFIRE-1314
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1314
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Junit 4.x support
>    Affects Versions: 2.19.1
>            Reporter: Mikhail Stepura
>
> We're using {{surefire.rerunFailingTestsCoun}} property for our integration 
> tests, and everything working fine when an error/failure happens in a test 
> method (i.e. {{@Test}} ), and those test methods are re-executed later, as 
> expected.
> But if an error happens in a {{BeforeClass}} class method, then those test 
> classes are not re-executed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to