[ 
https://issues.apache.org/jira/browse/SUREFIRE-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045590#comment-16045590
 ] 

ASF GitHub Bot commented on SUREFIRE-1384:
------------------------------------------

Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/153#discussion_r121260270
  
    --- Diff: 
surefire-integration-tests/src/test/resources/junit-plattform/src/test/java/junitplattform/BasicTest.java
 ---
    @@ -0,0 +1,65 @@
    +package junitplattform;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +import static org.junit.jupiter.api.Assertions.assertTrue;
    +
    +import org.junit.jupiter.api.AfterAll;
    +import org.junit.jupiter.api.AfterEach;
    +import org.junit.jupiter.api.BeforeEach;
    +import org.junit.jupiter.api.Test;
    +
    +public class BasicTest
    +{
    +
    +    private boolean setUpCalled = false;
    --- End diff --
    
    Default value `false` not needed.


> Add ProviderInfo for JUnit Plattform to enable automatic provider lookup
> ------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1384
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1384
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: JUnit 5.x support
>            Reporter: Benedikt Ritter
>             Fix For: 3.0-RC1
>
>
> In order to enable automatic provider lookup for JUnit Plattform/JUnit 5, we 
> need to add the corresponding ProviderInfo implementation to 
> AbstractSurefireMojo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to