[
https://issues.apache.org/jira/browse/MRESOLVER-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048751#comment-16048751
]
ASF GitHub Bot commented on MRESOLVER-8:
----------------------------------------
Github user ChristianSchulte commented on the issue:
https://github.com/apache/maven/pull/107
You'll need to merge the resolver bugfixes as well to make the IT work, of
course.
[MRESOLVER-8](https://github.com/ChristianSchulte/maven-resolver/commit/2813a8f9e290f8a6523486c0ca30cca8c9b7cc45)
[MRESOLVER-9](https://github.com/ChristianSchulte/maven-resolver/commit/67a37de1feabcb420152981cd9b07c2288b46108)
This will make the resolver discard any non-transitive dependencies
(optional and test-scope) correctly. Existing builds relying on the incorrect
behaviour will stop working. The POMs of the resolver itself rely on that
incorrect behaviour. Working on those issues is a waste of time! It will sadly
never pass a release vote.
I haven't split the unit tests into smaller commits. To be able to merge
the unit tests, you'll need to merge the following commits as well.
[MRESOLVER-10](https://github.com/ChristianSchulte/maven-resolver/commit/fb743981623504a00bf88c6c060ced9d08880355)
[MRESOLVER-12](https://github.com/ChristianSchulte/maven-resolver/commit/e0f9180da1532adbdc30f5f9470c445a2d9cc199)
> ScopeDependencySelector incorrectly de-selects direct dependencies.
> -------------------------------------------------------------------
>
> Key: MRESOLVER-8
> URL: https://issues.apache.org/jira/browse/MRESOLVER-8
> Project: Maven Resolver
> Issue Type: Bug
> Reporter: Christian Schulte
> Priority: Critical
> Fix For: Maven Artifact Resolver 1.2.0 pre-reset
>
>
> The {{ScopeDependencySelector}} decides if a node is a direct dependency or
> transitive dependency differently based on the request performed. For the
> {{CollectRequest.setRootArtifact(Artifact)}} case, the class is working
> correctly. For the {{CollectRequest.setRoot(Dependency)}} case, the class is
> de-selecting direct dependencies instead of transitive dependencies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
