[
https://issues.apache.org/jira/browse/MRELEASE-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130635#comment-16130635
]
Caspar MacRae commented on MRELEASE-987:
----------------------------------------
Hi Michael,
Bit of a red herring - TL/DR; I'd mistakenly taken the *indentSize*
configuration property as applying to the POM edit for {{<scm><tag>}}, but
that's coming from {{maven-plugin-plugin:helpmojo}} AFAICS and doesn't apply in
this case. The issue appears to be hardcoding in modello xpp3.
When I run the release plugin it updates the {{<scm><tag>}} value (e.g. my git
project has {{HEAD}} for dev branch and {{${tagNameFormat}}} for the tagged
release).
My issue is that this is being indented with 2 spaces - however I use tabs
consistently throughout (and have profiles for validating and auto-formatting
source/POM, license headers etc).
I understand the Apache Maven conventions for POM formatting via
http://maven.apache.org/developers/conventions/code.html#XML_Code_Style but
that should only be enforced in Apache land. (I'm using the
{{org.codehaus.mojo:tidy-maven-plugin}}, which doesn't appear to have setting
for spaces v tabs, but does honour existing tab indented POMs).
Had a quick look at the code see if I could try a quick pull request could be
made, but it's not obvious to me.
In latest
[811fee8](https://github.com/apache/maven-release/commit/811fee84a24895ba5304c896df7ebca10edabc83),
in the generated file {{ReleaseDescriptorXpp3Writer.java}} there are lines:
{code:java}
serializer.setProperty(
"http://xmlpull.org/v1/doc/properties.html#serializer-indentation";, " " );
{code}
Looking at
[org.codehaus.modello:modello-maven-plugin:1.9.0-SNAPSHOT:xpp3-writer](http://codehaus-plexus.github.io/modello//modello-maven-plugin/xpp3-writer-mojo.html)
and
[Xpp3WriterGenerator.java](https://github.com/codehaus-plexus/modello/blob/master/modello-plugins/modello-plugin-xpp3/src/main/java/org/codehaus/modello/plugin/xpp3/Xpp3WriterGenerator.java)
there doesn't appear to be an option for tabs instead of spaces.
So it transpires this isn't an issue with the release plugin specifically, I've
raised an issue on the [modello github tracker
#14](https://github.com/codehaus-plexus/modello/issues/14) and have linked back
to this ticket.
Apologies for not digging deeper before raising spam ticket, I'll mark this
resolved now hope that's ok.
cheers,
Caspar
> Support tab as indent char
> --------------------------
>
> Key: MRELEASE-987
> URL: https://issues.apache.org/jira/browse/MRELEASE-987
> Project: Maven Release Plugin
> Issue Type: Wish
> Reporter: Caspar MacRae
> Priority: Minor
>
> It would be great if the maven-release-plugin honoured the indent character
> when writing the SCM tag.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
