Karl Heinz Marbaise created MSHARED-655:
-------------------------------------------
Summary: ArtifactInstaller check for integrity of parameters null,
empty collection, being a directory
Key: MSHARED-655
URL: https://issues.apache.org/jira/browse/MSHARED-655
Project: Maven Shared Components
Issue Type: Improvement
Components: maven-artifact-transfer
Affects Versions: maven-artifact-transfer-0.9.1
Reporter: Karl Heinz Marbaise
Priority: Minor
Fix For: maven-artifact-transfer-1.0.0
Currently the interface {{ArtifactInstaller}} contains the two methods:
{code:java}
public interface ArtifactInstaller
{
void install( ProjectBuildingRequest request, Collection<Artifact>
mavenArtifacts );
void install( ProjectBuildingRequest request, File localRepository,
Collection<Artifact> mavenArtifacts );
}
{code}
We should make sure that {{ProjectBuildRequest}} can't be null. Furthermore the
{{mavenArtifacts}} should also being checked for {{null}. We need to think if
an {{empty}} collection is allowed or not? (I think it should not being
allowed?)
Apart from that the {{localRepository}} should be checked for {{null}} and it
should be checked for being a directory if it is not {{null}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)