[ https://issues.apache.org/jira/browse/SUREFIRE-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144476#comment-16144476 ]
ASF GitHub Bot commented on SUREFIRE-1391: ------------------------------------------ Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/159 @andrew-j-cohen Please close this PR. It was already merged in Surefire project. > System Property variables processed twice in calculation of effective > properties > -------------------------------------------------------------------------------- > > Key: SUREFIRE-1391 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1391 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin > Reporter: Andrew Cohen > Assignee: Michael Osipov > Priority: Trivial > Fix For: 2.20.1 > > Attachments: > 0001-SUREFIRE-1391-Eliminate-redundant-call-to-process-sy.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > System property variables are processed twice in the calculation of effective > properties. There is obviously no adverse impact on behavior, just > unnecessary processing. > {code:java} > static SurefireProperties calculateEffectiveProperties( Properties > systemProperties, > Map<String, > String> systemPropertyVariables, > Properties > userProperties, SurefireProperties props ) > { > SurefireProperties result = new SurefireProperties(); > result.copyPropertiesFrom( systemProperties ); > result.copyPropertiesFrom( props ); > copyProperties( result, systemPropertyVariables ); > copyProperties( result, systemPropertyVariables ); > // We used to take all of our system properties and dump them in with > the > // user specified properties for SUREFIRE-121, causing SUREFIRE-491. > // Not gonna do THAT any more... instead, we only propagate those > system properties > // that have been explicitly specified by the user via -Dkey=value on > the CLI > result.copyPropertiesFrom( userProperties ); > return result; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)