[ 
https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145247#comment-16145247
 ] 

ASF GitHub Bot commented on SUREFIRE-1383:
------------------------------------------

GitHub user owenfarrell opened a pull request:

    https://github.com/apache/maven-surefire/pull/164

    SUREFIRE-1383: Split IT569 in to multiple lifecycles

    @Tibor17 - Based on [your 
comment](https://github.com/apache/maven-surefire/pull/157#issuecomment-325616922),
 is this in line with your expectations?
    
    Refactored test passes based on contents of master.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/owenfarrell/maven-surefire IT569

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #164
    
----
commit 2892ec9778d05f7ecdafe87f0a9714981bdc1237
Author: Owen Farrell <owen.farr...@gmail.com>
Date:   2017-08-29T12:54:25Z

    SUREFIRE-1383: Split IT569 in to multiple lifecycles

----


> dependenciesToScan Does Not Leverage Classpath Elements 
> --------------------------------------------------------
>
>                 Key: SUREFIRE-1383
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1383
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.20
>            Reporter: Owen Farrell
>            Assignee: Tibor Digana
>             Fix For: 2.20.1
>
>         Attachments: scanned-dependencies-sample.zip
>
>
> The <dependenciesToScan> configuration attribute relies solely on installed 
> artifacts. This is an issue when the targeted dependencies were built as part 
> of the current session. The net result is that stale artifacts are used (i.e. 
> if the dependency has changed since it was last installed) or the tests are 
> not executed at all (if the dependency has not been previously installed.
> Attached is a sample project that illustrates this issue:
> Given I have a multi-module project
>    And the first module built includes test classes as part of the project 
> artifact
>    And subsequent modules scan the first for unit tests to execute
> When I execute the _*test*_ goal (prior to any install)
> Then the build should succeed
>    And tests should be executed with each module



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to