[ 
https://issues.apache.org/jira/browse/MNG-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169252#comment-16169252
 ] 

Hervé Boutemy commented on MNG-6282:
------------------------------------

just for the records, as detailed on 
https://github.com/fusesource/jansi/issues/94#issuecomment-329976333 , the root 
cause looks like Cygwin and MSYS don't create real terminals but 
pseudo-terminals, that isatty -- as expected -- detects as non-terminal, then 
Jansi has to implement additional pseudo terminal detection from Cygwin and 
MSYS naming convention, as it is done in Git for Windows 
https://github.com/git/git/commit/86924838e3d881cda2192fd79ac3a58aad75efd3

thank you [~dejan2609] for your help on this one, without you, I would not have 
found the root cause. It's great to have multiple people, with multiple 
approaches, working together

> Console output has no colors in shell (both Git Bash and Cygwin) [regression 
> in Jansi 1.16 / Maven 3.5.1]
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-6282
>                 URL: https://issues.apache.org/jira/browse/MNG-6282
>             Project: Maven
>          Issue Type: Bug
>          Components: Logging
>    Affects Versions: 3.5.1
>            Reporter: Dejan Stojadinović
>              Labels: regression, windows
>         Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png, 
> screenshot-4.png, screenshot-5-Cygwin.png, screenshot-6.png, screenshot-7.png
>
>
> See 
> [screenshot|https://issues.apache.org/jira/secure/attachment/12886398/screenshot-1.png]
>  for more details.
> _*Environment:*_
> * Windows 10, 64 bit
> * Oracle Java, version: *1.8.0_144*
> * Git Bash shell (MINGW64), Cygwin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to