[ 
https://issues.apache.org/jira/browse/SUREFIRE-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192678#comment-16192678
 ] 

Dan Berindei commented on SUREFIRE-1426:
----------------------------------------

{quote}
The system property maven.test.failure.ignore is not about masking your user 
error nor system error. This is about ignoring events coming from JUnit 
reflecting exception like Assumption|AssertionError or ordinal exception caught 
by JUnit thrown by you test code.
{quote}

Then why does the build fail with {{-Dmaven.test.failure.ignore=false}} and 
pass with {{-Dmaven.test.failure.ignore=true}}?

{quote}
I am no more willing to mask OutOfMemoryError and not to mask wrong 
configuration because otherwise running tests would not makes sense!
{quote}

And yet Surefire *does* mask an OutOfMemoryError in the fork, if it happens in 
the Surefire code and not in the user code.

{quote}
Then why you executed mvn test if you do not expect to run tests?
{quote}

That's exactly what I want, to run tests. But if I made a mistake and Surefire 
cannot run the tests, I want to know so I can fix that mistake.

{quote}
And why you use maven.test.failure.ignore which everybody knows that it is 
highly unrecommended in good s/w development 
{quote}

Why exactly is {{-Dmaven.test.failure.ignore}} so highly unrecommended? Could 
it be because it ignores all user and system errors, not just test failures?

Jenkins can read test results from the XMLs and mark the build as unstable or 
failed, so {{-Dmaven.test.failure.ignore=false}} would work perfectly well in 
this scenario *if* it ignored only test failures and not all the errors that 
happen in the fork process.

{quote}
and why you simply did not skip tests -DskipTests if you do not like writing 
and maintaining tests and you do not like high quality of s/w?
{quote}

What did I say to make you draw that conclusion? The fact that in a build with 
20k+ tests I want more information than "no test failed" vs "at least one test 
failed"?

> Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true
> -------------------------------------------------------------------
>
>                 Key: SUREFIRE-1426
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1426
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: process forking
>            Reporter: Dan Berindei
>            Assignee: Tibor Digana
>         Attachments: surefire-1426-test.tar.gz
>
>
> We have a reactor with many modules, and also a few random test failures. We 
> want to run the tests of all the modules even if a test failed in the core 
> module, so we use {{mvn -Dmaven.test.failure.ignore=true}}. {{mvn 
> --fail-at-end}} only builds the modules that do not depend on the module with 
> a failed test.
> The problem is that fork crashes like this one are written to the surefire 
> reports, so Jenkins ignores them:
> {noformat}
> org.apache.maven.surefire.booter.SurefireBooterForkException: There was an 
> error in the forked process
> Unable to load category: stress
>       at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:665)
>       at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
>       at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:279)
>       at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:243)
>       at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1077)
>       at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:907)
>       at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:785)
>       at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>       at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>       at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>       at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>       at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>       at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>       at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>       at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>       at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>       at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>       at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>       at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>       at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>       at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>       at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>       at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>       at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356){noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to