[ 
https://issues.apache.org/jira/browse/SUREFIRE-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194916#comment-16194916
 ] 

Jesse Glick commented on SUREFIRE-1226:
---------------------------------------

This has nothing to do with Jenkins plugins specifically. I just happened to be 
testing a Jenkins plugin when I ran into this bug.

The suggestions for smarter trimming algorithms and for clearer display of 
where trimming has occurred are fine for future (3.x) releases, but I would 
urge you to change the default for {{trimStackTrace}} to {{false}} right away 
(a minor 2.x update).

In 2.18.1- there is a feature with broad benefits—almost everyone will have 
tons of meaningless stack trace lines before their test case—and a very limited 
downside—only people with rather exotic test runners or custom rules would need 
to see details of such wrapping calls in order to troubleshoot test failures. 
Thus having the feature be on by default was reasonable.

In 2.19+ there is a feature with slightly broader benefits—almost everyone will 
appreciate trimming lots of lines at the bottom, and many test cases could 
benefit from trimming a few more at the top—and a massive downside: a 
completely routine test failure caused by an exception in code being tested 
will result in an impossible-looking stack trace with no hint given to the 
programmer that their test code is perfectly fine and it is the test reporting 
tool which is to blame, and no easy way to find this out besides bisecting 
plugin versions and Googling for a problem with no clear keyword match. So 
having such a feature be on by default is quite inappropriate.

> Surefire trims all stack trace elements except those in the test that failed
> ----------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1226
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1226
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.19
>            Reporter: Jiri Locker
>            Assignee: Tibor Digana
>            Priority: Minor
>         Attachments: mvn_stacktrace.tar.gz
>
>
> This looks like a re-occurrence of SUREFIRE-992 but now the stack trace is 
> even more trimmed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to