joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena? URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342886972 Thanks, Herv?! > But I don't understand what this change does: can you describe a little bit the issue (what a "hamburger menu" is)? See https://en.wikipedia.org/wiki/Hamburger_button for starters :). If you visit https://hbase.apache.org/ on your mobile or shrink down the page in a browser, you'll see the nav-bar at the top of the page convert into a drop-down with the "stacked-lines" (hamburger) button to open/close it. > Is there one existing IT that show clearly the issue (then the fix)? Admittedly, I didn't look at all into how to test :D. Have any pointers/docs/suggestions on what kind of test would be effective? > Sidenote: this is a generic topic with Skins, ie understanding html/css changes. Any generic idea on how to describe an issue and a fix, between "designer oriented" people (who are html/css experts) and "java dev" oriented people (like Maven developpers, like me, who is not proficient at all with modern html/css, who need to judge before merging...) Ditto. CSS has changed drastically since I've done anything of consequence with it :D. I'm mostly repurposing Misty's original commit here. My general understanding is that bootstrap is doing some special logic when the "window" (or maybe screen is more appropriate) reduces to a certain size. Then it uses some CSS rules to convert the content into the dynamic drop-down instead of how it appears on screens with adequate width.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
