[ 
https://issues.apache.org/jira/browse/MINVOKER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250155#comment-16250155
 ] 

Alberto Scotto commented on MINVOKER-228:
-----------------------------------------

Hi [~rfscholte],

Thanks for looking into it.

I think we should really have the install goal uncommented.

{quote}
The page is about explaining the difference between invoker:run and 
invoker:integration-test+invoker:verify.
{quote}

To me it looks like that page is about more than that:

{quote}
[..] or if you need to setup an integration test enviroment prior to test 
execution and tear that envronment down afterwards [..]
{quote}

And that's exactly my use case, BTW.
FWIW, more specifically, I'm using the docker-maven-plugin to have a container 
with a real database ready right before running my integration tests with the 
maven-invoker-plugin.
Without my plugin under test installed, what am I gonna test?

Generally speaking, I can't think of any scenario where one may want _not_ to 
install the plugin under test before running the tests?

> Improve documentation: "Using with other integration test frameworks" page
> --------------------------------------------------------------------------
>
>                 Key: MINVOKER-228
>                 URL: https://issues.apache.org/jira/browse/MINVOKER-228
>             Project: Maven Invoker Plugin
>          Issue Type: Task
>            Reporter: Alberto Scotto
>            Assignee: Robert Scholte
>             Fix For: 3.0.2
>
>
> https://maven.apache.org/plugins/maven-invoker-plugin/examples/integration-test-verify.html
> In the example the goal 'install' is missing from the list of goals under the 
> tag execution.
> This causes the integration tests to either use an old version of the plugin 
> under test, or just fail if the plugin has never been installed in the local 
> M2 repo before.
> Please fix the example to be like this:
> {code:java}
> <project>
>   <build>
>     <plugins>
>       <plugin>
>         <artifactId>maven-invoker-plugin</artifactId>
>         <version>3.0.1</version>
>         <executions>
>           <execution>
>             <id>integration-test</id>
>             <goals>
>               <goal>install</goal>
>               <goal>integration-test</goal>
>               <goal>verify</goal>
>             </goals>
>           </execution>
>         </executions>
>       </plugin>
>     </plugins>
>   </build>
> </project>
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to