[ http://jira.codehaus.org/browse/MCHANGELOG-16?page=comments#action_77666 
] 
            
Julian Wood commented on MCHANGELOG-16:
---------------------------------------

I've linked to the original report. As I remember, we patched, then Maven 
changed somewhat substantially, which broke this patch, and so we patched 
again. That's what this report is (was) about. I think you're looking for the 
original report.

As for distinct signatures, I don't really think there is one, but I also don't 
think that's necessary. The developer should simply be able to choose what URL 
they would like to use in order to present files out of their chosen scm. 
There's no reason why it should break any system at all.

I think the original patch was designed to simply see if the 
displayFileDetailURL had been set, and only do something if it had. If it 
wasn't doing that, then there is a bug in the patch, which should be trivial to 
fix. That is a possible way forward.

BTW your suggestion about the parallel with changes is exactly right.

Thanks,

J

> when using svn, links are wrong
> -------------------------------
>
>                 Key: MCHANGELOG-16
>                 URL: http://jira.codehaus.org/browse/MCHANGELOG-16
>             Project: Maven 2.x Changelog Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: osx 10.4.5, java 1.4.2_09
>            Reporter: Julian Wood
>            Priority: Minor
>         Attachments: MCHANGELOG-16.patch, test.zip
>
>
> Here's my setup:
>   <scm>
>     <connection>scm:svn:http://apollo.ucalgary.ca:8800/pmgt/trunk</connection>
>     
> <developerConnection>scm:svn:http://apollo.ucalgary.ca:8800/pmgt/trunk</developerConnection>
>     
> <url>http://apollo.ucalgary.ca/websvncommons/listing.php?repname=pmgt&amp;rev=0&amp;sc=0&amp;path=/trunk</url>
>   </scm>
>   ...
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-changelog-plugin</artifactId>
>         <version>2.0-beta-2-SNAPSHOT</version>
>         <reportSets>
>           <reportSet>
>             <id>changes</id>
>             <configuration>
>               
> <displayFileDetailUrl>http://apollo.ucalgary.ca/websvncommons/filedetails.php?repname=pmgt&amp;rev=0&amp;sc=0&amp;path=</displayFileDetailUrl>
>               <type>range</type>
>               <range>90</range>
>             </configuration>
>             <reports>
>               <report>changelog</report>
>               <report>file-activity</report>
>               <report>dev-activity</report>
>             </reports>
>           </reportSet>
>         </reportSets>
>       </plugin>
> With that displayFileDetailUrl, I get links like this in the resultant 
> changelog in my site:
> http://apollo.ucalgary.ca/websvncommons/filedetails.php/trunk/pmgt-webapp/src/main/webapp/links/create_groups.jsp?repname=pmgt&sc=0&path=
> but it should be like this:
> link = 
> http://apollo.ucalgary.ca/websvncommons/filedetails.php?repname=pmgt&sc=0&rev=0&path=/trunk/pmgt-webapp/src/main/webapp/links/create_groups.jsp

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to