[
https://issues.apache.org/jira/browse/JXR-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266898#comment-16266898
]
ASF GitHub Bot commented on JXR-100:
------------------------------------
bhav0904 commented on issue #2: [JXR-100] Fix cross reference generation where
there are spaces befor..
URL: https://github.com/apache/maven-jxr/pull/2#issuecomment-347204846
It’s not, it was an unused method that I found and wanted to clean up.
On Mon, 27 Nov 2017 at 9:31 AM, Robert Scholte <notificati...@github.com>
wrote:
> *@rfscholte* commented on this pull request.
> ------------------------------
>
> In maven-jxr/src/main/java/org/apache/maven/jxr/JavaCodeTransform.java
> <https://github.com/apache/maven-jxr/pull/2#discussion_r153211196>:
>
> > @@ -676,25 +676,6 @@ public final String xrLine( String line, String
packageName, ClassType classType
> return buff.toString();
> }
>
> - /**
> - * Highlight the package in this line.
> - *
> - * @param line input line
> - * @param packageName package name
> - * @return input line with linked package
> - */
> - public final String xrLine( String line, String packageName )
>
> I don't think the removal of this method is part of the issue
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-jxr/pull/2#pullrequestreview-79184034>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/ABtG0QriTlpt_4ryEA-MXcgXrQUE_J0Mks5s6se2gaJpZM4QrBLp>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Method declaration: using spaces before or after parenthesis prevents cross
> references generation
> -------------------------------------------------------------------------------------------------
>
> Key: JXR-100
> URL: https://issues.apache.org/jira/browse/JXR-100
> Project: Maven JXR
> Issue Type: Bug
> Components: jxr
> Affects Versions: 2.3
> Reporter: Davide Cavestro
> Assignee: Robert Scholte
> Attachments: missinglinks.png, my-app.zip
>
>
> Launching JXR on a file containing method declarations with no spaces between
> the method name and the parenthesis also generates links to method parameters
> types.
> Adding a whitespace before or after method declaration prevents link
> generation, i.e. I get the method declaration in plain text, with no
> clickable reference to _App_ type.
> !missinglinks.png!
> I've attached the example project as [^my-app.zip].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
