[ 
https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325379#comment-16325379
 ] 

ASF GitHub Bot commented on MPLUGIN-331:
----------------------------------------

hboutemy commented on issue #10: [MPLUGIN-331] Let plugin:report support 
takari-maven-plugin packaging
URL: https://github.com/apache/maven-plugin-tools/pull/10#issuecomment-357475458
 
 
   ok, I'll mark it as read only

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Check the existence of plugin.xml rather than project packaging in 
> PluginReport.canGenerateReport()
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MPLUGIN-331
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-331
>             Project: Maven Plugin Tools
>          Issue Type: Task
>          Components: Plugin Plugin
>            Reporter: Peter Palaga
>            Assignee: Hervé Boutemy
>             Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently 
> reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
>                 || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to