ASF GitHub Bot commented on SUREFIRE-1004:

Github user bindul commented on the issue:

    I have reviewed the Maven Coordinates documentation you mentioned, and I 
can switch the order of elements in the parameter easily. However, I think I 
would disagree with requiring the version to be last element in the coordinates 
in this use case. As the functionality stands, the `dependenciesToScan` 
configuration does not add additional dependencies to the test scope of the 
project, it filters dependencies already added to the test scope in the project 
to allow for scanning test classes to run. If someone wants to add say a 
classfier or a type/packaging, requiring them them to also mention the version 
of the dependency would just make maintainers life harder by having another 
location to keep the version of the dependency in sync.
    As such I propose, we keep the version as optional and support the 
following variations of dependencies to scan:
    - `groupId:artifactId`
    - `groupId:artifactId:packaging/type`
    - `groupId:artifactId:packaging/type::version`
    - `groupId:artifactId:packaging/type:classifier`
    - `groupId:artifactId::classifier`
    - `groupId:artifactId::classifier:version`
    - `groupId:artifactId:packaging/type:classifier:version`
    It still maintains the same order of elements as the Maven Coordinates 
documentation in the POM, just makes the version not required to be the last 
element, or rather makes version optional.

> Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT
> --------------------------------------------------------------------
>                 Key: SUREFIRE-1004
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1004
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin
>    Affects Versions: 2.15
>            Reporter: Andreas Gudian
>            Priority: Major
> * Enhance what has been built with SUREFIRE-569 to support patterns as in 
> maven-shade-plugin. Use maven-common-artifact-filters for that.
> * Add/Adapt documentation and examples.

This message was sent by Atlassian JIRA

Reply via email to