Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/173
  
    Thx for your work. I will get back to you soon. Right now I am working on
    branch SUREFIRE-1463 which contains few fixes. I plan to finish this,
    including build script, and then I would push my changes. I will make a
    code review in this PR as I do in every other before accepting. Please wait
    for me meanwhile.
    
    On Sat, Feb 10, 2018 at 1:42 AM, Bindul Bhowmik <notificati...@github.com>
    wrote:
    
    > @Tibor17 <https://github.com/tibor17>
    >
    > I have reviewed the Maven Coordinates documentation you mentioned, and I
    > can switch the order of elements in the parameter easily. However, I think
    > I would disagree with requiring the version to be last element in the
    > coordinates in this use case. As the functionality stands, the
    > dependenciesToScan configuration does not add additional dependencies to
    > the test scope of the project, it filters dependencies already added to 
the
    > test scope in the project to allow for scanning test classes to run. If
    > someone wants to add say a classfier or a type/packaging, requiring them
    > them to also mention the version of the dependency would just make
    > maintainers life harder by having another location to keep the version of
    > the dependency in sync.
    >
    > As such I propose, we keep the version as optional and support the
    > following variations of dependencies to scan:
    >
    >    - groupId:artifactId
    >    - groupId:artifactId:packaging/type
    >    - groupId:artifactId:packaging/type::version
    >    - groupId:artifactId:packaging/type:classifier
    >    - groupId:artifactId::classifier
    >    - groupId:artifactId::classifier:version
    >    - groupId:artifactId:packaging/type:classifier:version
    >
    > It still maintains the same order of elements as the Maven Coordinates
    > documentation in the POM, just makes the version not required to be the
    > last element, or rather makes version optional.
    >
    > Thoughts?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > 
<https://github.com/apache/maven-surefire/pull/173#issuecomment-364609503>,
    > or mute the thread
    > 
<https://github.com/notifications/unsubscribe-auth/AA_yR2UI0i46PG43W3OWYyJ0NwaY_X9Pks5tTOYHgaJpZM4RcCcQ>
    > .
    >
    
    
    
    -- 
    Cheers
    Tibor



---

Reply via email to