[ 
https://issues.apache.org/jira/browse/WAGON-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Basin updated WAGON-498:
-----------------------------
    Description: 
See SCM-867

By default, CVSNT will corrupt jars during `mvn deploy`. Vanilla CVS less 
likely, but still possible due to Keyword substitution. ScmWagon needs to 
perform checkout and add commands with the '-kb' flag (binary).

For that we need to call the overloaded methods added recently in maven-scm 
1.9.6.

UPD: As it turns out, svn may also change files, if enable-auto-props is on. 
The test case "testWagon" which could reveal that is disabled by mistake: it 
runs only if supportsGetIfNewer(), but we don't call getIfNewer() there.

To demonstrate the issue, edit your subversion config file:
{code:java}
[miscellany]
enable-auto-props = yes
[auto-props]
test-resource = svn:eol-style=CRLF{code}
This will not affect checkin, because the test file already has LF, but the 
auto property will be set and next time the file will be checked out with CRLF 
and #testWagon will fail.

  was:
See SCM-867

By default, CVSNT will corrupt jars during `mvn deploy`. Vanilla CVS less 
likely, but still possible due to Keyword substitution. ScmWagon needs to 
perform checkout and add commands with the '-kb' flag (binary).

For that we need to call the overloaded methods added recently in maven-scm 
1.9.6.

UPD: As it turns out, svn may also change files, if enable-auto-props is on. 
The test case "testWagon" which could reveal that is disabled by mistake: it 
runs only if supportsGetIfNewer(), but we don't call getIfNewer() there.


> ScmWagon should work in binary mode when possible
> -------------------------------------------------
>
>                 Key: WAGON-498
>                 URL: https://issues.apache.org/jira/browse/WAGON-498
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-scm
>    Affects Versions: 3.0.0, 3.0.1
>            Reporter: Ilya Basin
>            Priority: Major
>
> See SCM-867
> By default, CVSNT will corrupt jars during `mvn deploy`. Vanilla CVS less 
> likely, but still possible due to Keyword substitution. ScmWagon needs to 
> perform checkout and add commands with the '-kb' flag (binary).
> For that we need to call the overloaded methods added recently in maven-scm 
> 1.9.6.
> UPD: As it turns out, svn may also change files, if enable-auto-props is on. 
> The test case "testWagon" which could reveal that is disabled by mistake: it 
> runs only if supportsGetIfNewer(), but we don't call getIfNewer() there.
> To demonstrate the issue, edit your subversion config file:
> {code:java}
> [miscellany]
> enable-auto-props = yes
> [auto-props]
> test-resource = svn:eol-style=CRLF{code}
> This will not affect checkin, because the test file already has LF, but the 
> auto property will be set and next time the file will be checked out with 
> CRLF and #testWagon will fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to