[ 
https://issues.apache.org/jira/browse/MNG-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386788#comment-16386788
 ] 

ASF GitHub Bot commented on MNG-6370:
-------------------------------------

GitHub user slachiewicz opened a pull request:

    https://github.com/apache/maven/pull/161

    [MNG-6370] Fix typo in list filtering ConcurrencyDependencyGraph.getU…

    …nfinishedProjects

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/slachiewicz/maven fix/MNG-6370

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit 683504fdcd0d901a06c9b49463175d9076299925
Author: Sylwester Lachiewicz <slachiewicz@...>
Date:   2018-03-05T21:24:14Z

    [MNG-6370] Fix typo in list filtering 
ConcurrencyDependencyGraph.getUnfinishedProjects

----


> Actual argument type 'HashSet<MavenProject>' is incompatible with expected 
> argument type 'MavenProject'.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-6370
>                 URL: https://issues.apache.org/jira/browse/MNG-6370
>             Project: Maven
>          Issue Type: Bug
>            Reporter: Sylwester Lachiewicz
>            Priority: Trivial
>
> Fix _ConcurrencyDependencyGraph.getUnfinishedProjects_
> {code:java}
> private final HashSet<MavenProject> finishedProjects = new HashSet<>();
> /**
>  * @return set of projects that have yet to be processed successfully by the 
> build.
>  */
> public Set<MavenProject> getUnfinishedProjects()
> {
>  Set<MavenProject> unfinished = new HashSet<>( projectBuilds.getProjects() );
>  unfinished.remove( finishedProjects );
>  return unfinished;
> }{code}
> replace _remove()_ with _removeAll()_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to