[ 
https://issues.apache.org/jira/browse/MNG-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387544#comment-16387544
 ] 

ASF GitHub Bot commented on MNG-6370:
-------------------------------------

Github user michael-o commented on the issue:

    https://github.com/apache/maven/pull/161
  
    @slachiewicz I am ready to merge, @rfscholte [requested a unit 
test](https://www.mail-archive.com/dev@maven.apache.org/msg116360.html).  Can 
you add one and I will merge it with a smile=


> ConcurrencyDependencyGraph#getNumberOfBuilds() does not remove finished 
> projects from unfinished ones
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MNG-6370
>                 URL: https://issues.apache.org/jira/browse/MNG-6370
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 3.5.2, 3.5.3
>            Reporter: Sylwester Lachiewicz
>            Assignee: Michael Osipov
>            Priority: Trivial
>             Fix For: 3.5.4-candidate
>
>
> Fix _ConcurrencyDependencyGraph.getUnfinishedProjects_
> {code:java}
> private final HashSet<MavenProject> finishedProjects = new HashSet<>();
> /**
>  * @return set of projects that have yet to be processed successfully by the 
> build.
>  */
> public Set<MavenProject> getUnfinishedProjects()
> {
>  Set<MavenProject> unfinished = new HashSet<>( projectBuilds.getProjects() );
>  unfinished.remove( finishedProjects );
>  return unfinished;
> }{code}
> replace _remove()_ with _removeAll()_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to