[ 
https://issues.apache.org/jira/browse/MCOMPILER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388587#comment-16388587
 ] 

ASF GitHub Bot commented on MCOMPILER-205:
------------------------------------------

monperrus commented on a change in pull request #3: [MCOMPILER-205] fixes 
incremental compilation
URL: 
https://github.com/apache/maven-compiler-plugin/pull/3#discussion_r172674360
 
 

 ##########
 File path: 
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
 ##########
 @@ -750,36 +750,16 @@ else if ( 
CompilerConfiguration.CompilerReuseStrategy.ReuseSame.getStrategy().eq
 
         IncrementalBuildHelperRequest incrementalBuildHelperRequest = null;
 
-        if ( useIncrementalCompilation )
+        if ( !useIncrementalCompilation )
         {
             getLog().debug( "useIncrementalCompilation enabled" );
 
 Review comment:
   good point! fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> maven-compiler-plugin: incremental compilation broken
> -----------------------------------------------------
>
>                 Key: MCOMPILER-205
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-205
>             Project: Maven Compiler Plugin
>          Issue Type: Bug
>    Affects Versions: 3.1
>            Reporter: Lukas Fryc
>            Priority: Major
>         Attachments: hello.tgz, ignore-package-info.patch, 
> no-class-in-java-file.zip, only-recompile-changed.patch
>
>
> When we do {{clean}} -> {{compile}} -> {{compile}}, all Java sources are 
> re-compiled for second compilation steps:
> {code}
> [framework]$ mvn clean
> ...
> [framework]$ mvn compile
> ...
> [INFO] --- maven-compiler-plugin:3.1:compile (precompile-sources-for-cdk) @ 
> richfaces-framework ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 915 source files to 
> /mnt/workspace/workspaces/richfaces/richfaces5/framework/target/classes
> ...
> [framework]$ mvn compile
> ...
> [INFO] --- maven-compiler-plugin:3.1:compile (precompile-sources-for-cdk) @ 
> richfaces-framework ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 915 source files to 
> /mnt/workspace/workspaces/richfaces/richfaces5/framework/target/classes
> ...
> {code}
> The source code of the affected project: 
> https://github.com/richfaces/richfaces5/tree/077dcfc0a46d03d7ba9a7ac3e701a4adfb834c71



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to