[ 
https://issues.apache.org/jira/browse/SUREFIRE-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394459#comment-16394459
 ] 

ASF GitHub Bot commented on SUREFIRE-1495:
------------------------------------------

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/176#discussion_r173648002
  
    --- Diff: 
surefire-its/src/test/java/org/apache/maven/surefire/its/UnicodeTestNamesIT.java
 ---
    @@ -62,14 +65,13 @@ public void checkFileNamesWithUnicode()
                     unpacked.executeTest()
                             .assertTestSuiteResults( 2, 0, 0, 0 );
     
    -        TestFile surefireReportFile = 
outputValidator.getSurefireReportsFile( TXT_REPORT );
    +        TestFile surefireReportFile = 
outputValidator.getSurefireReportsFile( TXT_REPORT, UTF_8 );
             assertTrue( surefireReportFile.exists() );
    -        surefireReportFile.assertContainsText( 
"junit.twoTestCases.????Test" );
    +        surefireReportFile.assertContainsText( toUTF8( REPORT_FILE_CONTENT 
) );
    --- End diff --
    
    @Tibor17 isnt's obvious that
    toUTF8( REPORT_FILE_CONTENT ) not equals(REPORT_FILE_CONTENT)
    
    IMHO we could write a comment to explain why this toUTF8 is needed, or add a
    assertNotEquals(REPORT_FILE_CONTENT, toUTF8( REPORT_FILE_CONTENT ))


> Encoding of TXT report file should be configured by 
> ${project.reporting.outputEncoding} and MOJO parameter encoding
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1495
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1495
>             Project: Maven Surefire
>          Issue Type: New Feature
>            Reporter: Tibor Digana
>            Assignee: Tibor Digana
>            Priority: Major
>             Fix For: 3.0.0-M1
>
>
> According to the release vote [1] the integration test {{UnicodeTestNamesIT}} 
> fails due to Japanese encoding.
> The entire problem is with using only system file encoding in Surefire TXT 
> report files in {{target/surefire-reports}}, similar with Failsafe.
> [1]: [VOTE] Release Apache Maven Surefire Plugin version 2.21.0
> https://lists.apache.org/thread.html/eddec1bf40f900f07be67be9e79e686654fd6ec44c672a4ae58d4650@%3Cdev.maven.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to