[ 
https://issues.apache.org/jira/browse/MJAVADOC-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412775#comment-16412775
 ] 

ASF GitHub Bot commented on MJAVADOC-512:
-----------------------------------------

khmarbaise closed pull request #1: [MJAVADOC-512] - Even when 
<javadocVersion>1.8.0</javadocVersion> matches there still is a warning.
URL: https://github.com/apache/maven-javadoc-plugin/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java 
b/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
index 24ea1b9..487bb0f 100644
--- a/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
+++ b/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
@@ -3782,7 +3782,7 @@ private void setFJavadocVersion( File jExecutable )
                 throw new MavenReportException( "Unable to parse javadoc 
version: " + e.getMessage(), e );
             }
 
-            if ( javadocRuntimeVersion != jVersion && getLog().isWarnEnabled() 
)
+            if ( javadocRuntimeVersion.compareTo( jVersion ) != 0 && 
getLog().isWarnEnabled() )
             {
                 getLog().warn( "Are you sure about the <javadocVersion/> 
parameter? It seems to be " + jVersion );
             }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Even when <javadocVersion>1.8.0</javadocVersion> matches there still is a 
> warning.
> ----------------------------------------------------------------------------------
>
>                 Key: MJAVADOC-512
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-512
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>          Components: javadoc
>    Affects Versions: 3.0.0
>            Reporter: Jene Jasper
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: 3.0.1
>
>
> Even when {{<javadocVersion>1.8.0</javadocVersion>}} matches there still is 
> the following log message:
> {quote}[WARNING] Are you sure about the parameter? It seems to be 1.8.0.
> {quote}
>  
> See [https://github.com/apache/maven-javadoc-plugin/pull/1]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to