[ 
https://issues.apache.org/jira/browse/MASSEMBLY-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429809#comment-16429809
 ] 

ASF GitHub Bot commented on MASSEMBLY-775:
------------------------------------------

petteyg commented on issue #1: [MASSEMBLY-775] remove false OS-specific 
warnings/errors
URL: 
https://github.com/apache/maven-assembly-plugin/pull/1#issuecomment-379564783
 
 
   Copying from the JIRA ticket since it doesn't sync both ways...
   
   It's not checking "a path starting with / on a Windows system". Every one of 
those checks is for the destination path. It's checking a path starting with / 
as the target path in the assembled archive, which is utter nonsense. The 
zip/tar/whatever file isn't ever going to have "Windows" paths with drive 
letters in it (and if you supplied one as a target path, I suspect the archiver 
code is going to barf an exception at you because that's invalid in every 
archive format I know of - no need to duplicate a check in the assembly 
plugin). / is the appropriate way to specify the root directory of the target 
archive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Emit WARNING instead of ERROR
> -----------------------------
>
>                 Key: MASSEMBLY-775
>                 URL: https://issues.apache.org/jira/browse/MASSEMBLY-775
>             Project: Maven Assembly Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.5.5
>            Reporter: Karl Heinz Marbaise
>            Priority: Minor
>
> I have currently a build which creates several tar/tar.gz/zip archives etc.
> {code}
> [INFO] Reading assembly descriptor: src/main/assembly/descriptor-inner-tar.xml
> [INFO] Reading assembly descriptor: src/main/assembly/descriptor.xml
> [INFO] Building tar: C:\...\xyz-X.y.z-SNAPSHOT-dist.tar
> [ERROR] OS=Windows and the assembly descriptor contains a *nix-specific 
> root-relative-reference (starting with slash) /
> [ERROR] OS=Windows and the assembly descriptor contains a *nix-specific 
> root-relative-reference (starting with slash) /
> {code}
> In my opinion the message could be a WARNING instead of an error ? WDYT ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to