[
https://issues.apache.org/jira/browse/MSITE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443766#comment-16443766
]
Akira Ajisaka edited comment on MSITE-812 at 4/19/18 9:05 AM:
--------------------------------------------------------------
Thank you for your review, [~hboutemy]!
bq. what happens to "mvn site:stage
-DstagingDirectory=/Users/ajisaka/YARN-7736/" ?
The same. This is because the stagingDirectory is normalized by the following
source code.
{code:title=org/apache/maven/plugins/site/deploy/SiteStageMojo.java}
/**
* Staging directory location. This needs to be an absolute path, like
* <code>C:\stagingArea\myProject\</code> on Windows or
* <code>/stagingArea/myProject/</code> on Unix.
* If this is not specified, the site will be staged in
${project.build.directory}/staging.
*
* @since 2.3
*/
@Parameter( property = "stagingDirectory" )
private File stagingDirectory;
{code}
{code:title=java.io.File}
public File(String pathname) {
if (pathname == null) {
throw new NullPointerException();
}
this.path = fs.normalize(pathname);
this.prefixLength = fs.prefixLength(this.path);
}
{code}
Therefore, we don't need to check whether the staging directory ends with '/'
or not. Should I update the patch to use the utility
(AbstractDeployMojo#appendSlash) in case there are some changes in
stagingDirectory?
was (Author: ajisakaa):
bq. what happens to "mvn site:stage
-DstagingDirectory=/Users/ajisaka/YARN-7736/" ?
The same. This is because the stagingDirectory is normalized by the following
source code.
{code:title=org/apache/maven/plugins/site/deploy/SiteStageMojo.java}
/**
* Staging directory location. This needs to be an absolute path, like
* <code>C:\stagingArea\myProject\</code> on Windows or
* <code>/stagingArea/myProject/</code> on Unix.
* If this is not specified, the site will be staged in
${project.build.directory}/staging.
*
* @since 2.3
*/
@Parameter( property = "stagingDirectory" )
private File stagingDirectory;
{code}
{code:title=java.io.File}
public File(String pathname) {
if (pathname == null) {
throw new NullPointerException();
}
this.path = fs.normalize(pathname);
this.prefixLength = fs.prefixLength(this.path);
}
{code}
Therefore, we don't need to check whether the staging directory ends with '/'
or not. Should I update the patch to use the utility
(AbstractDeployMojo#appendSlash) in case there are some changes in
stagingDirectory?
> Missing '/' in log when deploying documentation by site:stage
> -------------------------------------------------------------
>
> Key: MSITE-812
> URL: https://issues.apache.org/jira/browse/MSITE-812
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: site:stage(-deploy)
> Affects Versions: 3.7
> Reporter: Akira Ajisaka
> Priority: Major
>
> When running {{mvn site:stage -DstagingDirectory=/Users/ajisaka/YARN-7736}}
> {noformat}
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Building Apache Hadoop Project POM 3.2.0-SNAPSHOT
> [INFO]
> ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-site-plugin:3.7:stage (default-cli) @ hadoop-project ---
> [INFO] Using this base directory for staging: /Users/ajisaka/YARN-7736
> [INFO] Pushing /Users/ajisaka/git/hadoop/hadoop-project/target/site
> [INFO] >>> to file:///Users/ajisaka/YARN-7736hadoop-project
> {noformat}
> '/' is missing between YARN-7736 and hadoop-project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
