hboutemy commented on issue #1: [MPDF-8] Create one PDF from a multi module project URL: https://github.com/apache/maven-pdf-plugin/pull/1#issuecomment-384276227 Hi Anthony, Thanks for this great contribution: it works like a charm. I'll send you a PR adding an IT. But there is one serious issue before I can merge: org.json dependency can't be used, since its license is not free (a little addition to MIT license that cause many headache to many lawyers) https://www.apache.org/legal/resolved.html#json please replace this dependency with another: Json format is not an issue, just this library A little enhancement for future work could also be to add a separator page for each module, since currently the swithc from one module to the next one is not really visible: but that one is not a blocker thanks again for your help: it is greatly appreciated
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
