Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386860668 I think it will work even without is( greaterThanOrEqualTo( "1.8" ) ). I have initially designed the Jenkinsfile with two JDK which is why we did not use the build that Maven core uses. Now we can utilize and run the unit tests on the top of JDK 1.8. The build process always runs with JDK 1.8. The unit and integration tests run with JDK 1.7 - 10 except for JUnit5 Provider and therefore the condition in setUp() should be always satisfied. On Sun, May 6, 2018 at 9:14 AM, Christian Stein <notificati...@github.com> wrote: > Did you also have a problem with JaCoCO:0.7.9 on JDK10? > > According to https://github.com/jacoco/jacoco/releases 0.8.1 introduced > JDK 10 support. Thus, 0.7.9 had to fail. > > Do we need to have scope=compile on the dependency junit-platform-launcher > in our provider POM? What will happen if it would be scope provided? > > 99% yes, the provider needs it at compile time. That's what JUnit Platform > is all about. It's the API for tools (build tools, IDEs, ...) to get "JUnit > 5" *(technically, there's no JUnit 5)* running. See this import > statements in org.apache.maven.surefire.junitplatform. > JUnitPlatformProvider: > > import org.junit.platform.launcher.Launcher;import org.junit.platform.launcher.LauncherDiscoveryRequest;import org.junit.platform.launcher.TagFilter;import org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder;import org.junit.platform.launcher.core.LauncherFactory; > > And recall the "JUnit 5" architecture layout: > > > <https://user-images.githubusercontent.com/214207/38951423-e2d5c82c-4348-11e8-94f0-840a0c78b617.png> > > Just move the *junit-platform-surefire-provider* from the bottom-left out > off the red *PLATFORM* box into the *IDEs/Build Tool* bubble at the > bottom. Here be dragons, Gradle, Surefire, IDEA, Eclipse, etc... > > 1% no, perhaps there's some Maven-trick to achieve the same with provided > scope? > > How did you skip tests on surefire-junit-platform with JDK 1.7? > > Mh, if it is because of <jvm>${java.home}/bin/java</jvm> then @britter > <https://github.com/britter> did it. > At test runtime, the assumption declared in JUnitPlatformIT ensures that > a JDK 1.8+ is at work: > > @Beforepublic void setUp() > { > assumeThat( "java.specification.version: ", > getProperty( "java.specification.version" ), > is( greaterThanOrEqualTo( "1.8" ) ) ); > } > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-surefire/pull/184#issuecomment-386859383>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA_yR1mdMwmYlIekyWiJXr7QymRl2pwyks5tvqLlgaJpZM4TwvA6> > . > -- Cheers Tibor
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
